Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update package building scripts #4273

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Fix and update package building scripts #4273

merged 5 commits into from
Apr 25, 2024

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Apr 23, 2024

This PR fixes and updates the packages built with CircleCI.

The original issue was that the packages.erlang-solutions.com/... repos stopped working. I reported this, and they are almost fully functional again (except for Centos 7).

In the meantime, I researched possible alternatives, because the repos are now considered old and discontinued.

  • Using the new repos binaries2.erlang-solutions.com/... would be a good option, but they don't work. I reported this, but it will take time to fix these issues.
  • Using directly downloaded packages from https://www.erlang-solutions.com/downloads/. This option worked correctly, so I used it.

With the new packages it was possible to update the Erlang versions, and add support for the newer Ubuntu 22.04 Jammy Jellyfish.

Notes:

  • I had to use a few different Erlang versions, because of the availability of downloadable packages. This should be fixed, because we need to support all distros for each new Erlang version, and currently it is random. I reported all the issues with ESL Erlang packages.
  • In the future we might want to support Arm64, but Erlang packages are not available atm, so it's a task for the future.
  • I had to remove RPaths from the rpm packages to avoid errors, just like here https://github.com/esl/packages-pipeline/blob/master/esl_erlang/ctx/scripts/rpm/script.sh#L100-L101.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (4c125a0) to head (05f03eb).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
+ Coverage   84.42%   84.44%   +0.02%     
==========================================
  Files         552      552              
  Lines       33554    33554              
==========================================
+ Hits        28328    28335       +7     
+ Misses       5226     5219       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the fix-packages branch 2 times, most recently from ae82786 to 70d28ff Compare April 23, 2024 10:33
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the fix-packages branch 2 times, most recently from f9e3fe1 to b7f9f3b Compare April 23, 2024 12:24
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz force-pushed the fix-packages branch 2 times, most recently from a58f69a to 1595250 Compare April 24, 2024 17:21
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz changed the title Disable cache when getting ESL packages Fix and update package building scripts Apr 25, 2024
Use direct download.

Reasons:
- The old repos at https://packages.erlang-solutions.com/...
  are failing from time to time, and the Erlang versions are not
  updated anymore.
- The new repos at http://binaries2.erlang-solutions.com/...
  are not functional (yet).
  I reported the issue, but it is not clear when they will start working.
Otherwise, rpmbuild would fail.

This is already done when building ESL Erlang packages.
Also:
- Add Ubuntu 22 Jammy Jellyfish

Note: Versions differ because of the available ESL Erlang packages.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 25, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 05f03eb
Reports root/ big
OK: 437 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0


small_tests_25 / small_tests / 05f03eb
Reports root / small


small_tests_26 / small_tests / 05f03eb
Reports root / small


small_tests_26_arm64 / small_tests / 05f03eb
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 05f03eb
Reports root/ big
OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 05f03eb
Reports root/ big
OK: 2284 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 05f03eb
Reports root/ big
OK: 4541 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 05f03eb
Reports root/ big
OK: 4541 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 05f03eb
Reports root/ big
OK: 4508 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 05f03eb
Reports root/ big
OK: 2424 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 05f03eb
Reports root/ big
OK: 4538 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 05f03eb
Reports root/ big
OK: 4456 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 05f03eb
Reports root/ big
OK: 4930 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 05f03eb
Reports root/ big
OK: 4909 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 05f03eb
Reports root/ big
OK: 4927 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 05f03eb
Reports root/ big
OK: 4930 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review April 25, 2024 08:24
Copy link
Contributor

@jacekwegr jacekwegr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍Thanks for fixing the package scripts!

@jacekwegr jacekwegr merged commit 56ff9c5 into master Apr 25, 2024
4 checks passed
@jacekwegr jacekwegr deleted the fix-packages branch April 25, 2024 09:20
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants