Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo poetry version pinning #475

Closed
dfsp-spirit opened this issue Apr 6, 2023 · 0 comments · Fixed by #482
Closed

Undo poetry version pinning #475

dfsp-spirit opened this issue Apr 6, 2023 · 0 comments · Fixed by #482
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@dfsp-spirit
Copy link
Collaborator

dfsp-spirit commented Apr 6, 2023

We pinned the poetry version to 1.4.0 in some places due to #451, this can be undone with the release of pydata-sphinx-theme v0.13.3, which fixes their issue 1253 that was the source of our problems.

We should undo the version pinning in:

  • our GitHub workflow files
  • our .gitlab-ci.yml file for the ESI runners

One thing to keep in mind when updating the version of pydata-sphinx-theme to >=0.13.3 is that we also need to update the version of sphinx-book-theme to >=1.0.1, as discussed in pydata-sphinx-theme issue 1274.

@dfsp-spirit dfsp-spirit self-assigned this Apr 6, 2023
@dfsp-spirit dfsp-spirit linked a pull request Apr 20, 2023 that will close this issue
4 tasks
@dfsp-spirit dfsp-spirit added the dependencies Pull requests that update a dependency file label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants