Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface additional cF returns #340

Closed
tensionhead opened this issue Aug 24, 2022 · 0 comments
Closed

Interface additional cF returns #340

tensionhead opened this issue Aug 24, 2022 · 0 comments
Assignees
@tensionhead
Labels
Feature Request A concrete request (as detailed as possible) to either add or change functionality.

Comments

@tensionhead
Copy link
Contributor

Now that we finally have the possibility to get more return values from our cFs thanks to #321 we should make use of it:

Granger

  • the Wilson factorization returns a boolean conv indicating successful termination of the algorithm which might be of interest
  • Potential regularization of the CSD also returns the factor

Specest Methods

  • everywhere where single trial freq axis appear, we could/should at least compare the hashes as in the end there is one global .freq
@tensionhead tensionhead added the Feature Request A concrete request (as detailed as possible) to either add or change functionality. label Aug 24, 2022
@tensionhead tensionhead self-assigned this Aug 24, 2022
@tensionhead tensionhead mentioned this issue Aug 29, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tensionhead tensionhead

Labels
Feature Request A concrete request (as detailed as possible) to either add or change functionality.
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

340-interface-additional-cf-returns esi-neuroscience/syncopy
1 participant
@tensionhead