Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace execa in vitest #57

Closed
benmccann opened this issue Jun 29, 2024 · 9 comments
Closed

Replace execa in vitest #57

benmccann opened this issue Jun 29, 2024 · 9 comments

Comments

@benmccann
Copy link

execa pulls in quite a few dependencies and vitest is heavily used - especially among this community

@benmccann
Copy link
Author

@AbhiPrasad
Copy link

I think the windows support + error handling makes this pretty hard to replace for a lot of users.

Looking at the dep graph, there is probably a good opportunity to modernize node-cross-spawn though.

@43081j
Copy link
Collaborator

43081j commented Jun 29, 2024

in the tinylibs org we're also working on a lighter alternative, but isn't quite ready yet just FYI

@TheDevMinerTV
Copy link

Package size report
===================

Package info for "[email protected]": 33 MB
  Released: 2024-07-15 10:03:50.134 +0000 UTC (1d ago)
  Downloads last week: 46,096 (0.89%)
  Estimated traffic last week: 1.5 TB
  Subdependencies: 101

Removed dependencies:
  - [email protected]: 308 kB (0.94%)
    Downloads last week: 11,322,011 (13.88%)
    Downloads last week from "[email protected]": 46,096 (0.41%)
    Estimated traffic last week: 3.5 TB
    Estimated traffic from "[email protected]": 14 GB (0.41%)
    Subdependencies: 18 (17.82%)

(didn't calculate in new dependencies)

Estimated package size: 33 MB → 32 MB (99.06%)
Estimated traffic over a week: 1.5 TB → 1.5 TB (14 GB saved)
Estimated traffic over a week @ 100% downloads: 170 TB → 168 TB (1.6 TB saved)

@43081j
Copy link
Collaborator

43081j commented Jul 17, 2024

tinyexec now exists too which could slot in nicely

Worth taking a look

@benmccann
Copy link
Author

There is agreement to use tinyexec if anyone would like to take a stab at it: vitest-dev/vitest#5713

@pralkarz
Copy link

pralkarz commented Sep 5, 2024

Submitted a PR for this change: vitest-dev/vitest#6454.

@TheDevMinerTV
Copy link

TheDevMinerTV commented Sep 6, 2024

Submitted a PR for this change: vitest-dev/vitest#6454.

Got merged, we can close this issue.

@benmccann
Copy link
Author

Woohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants