Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TypeScript definitions #48

Closed
andrewsantarin opened this issue Nov 26, 2019 · 3 comments
Closed

Add support for TypeScript definitions #48

andrewsantarin opened this issue Nov 26, 2019 · 3 comments

Comments

@andrewsantarin
Copy link
Contributor

Tried this module. Works great. But it's a bit doesn't have types built into it, so when I attempt to use it in a TypeScript project, the compiler complains. I've been looking for this in DefinitelyTyped.org but found nothing.

I've prepped a gist here:
https://gist.github.com/andrewsantarin/1aa57d63049798c33b22619c064afa07

@rakeshpai
Copy link
Member

Hi @andrewsantarin. This looks awesome. Could you create a PR for this, with the required changes to package.json to reference this .d.ts file? Also, it would be great if you could maintain the typings at least in the short time while we iron out any immediate issues with the types. But otherwise, this seems totally legit to add to the repo. 👍

@andrewsantarin
Copy link
Contributor Author

Will do, will do. 👌

@andrewsantarin
Copy link
Contributor Author

@rakeshpai done; see pull request #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants