fix: normalizePath tilde expansion on Windows #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normalizePath sometimes gets backslash paths as input. In such case it will not be able to act on the ~/ prefix, since it will be \~ instead. FromSlash will provide the correct variant.
lanvstn
force-pushed
the
normalizePath-windows-tilde
branch
from
7fb60dc to
613c518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalizePath sometimes gets backslash paths as input.
In such case it will not be able to act on the
~/prefix, since it will be\~instead.FromSlash will provide the correct variant.
An example where the error happens:
With
.vale.ini:StylesPath = ~/.vale/stylesWhen running Vale:
The test was wrongly failing after this change. The
normalizePathcallers tend to provideFromSlash'ed inputs, so the test has been adapted accordingly.