Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewdog Vale is slower compared to its ancestor #82

Closed
nickvigilante opened this issue Oct 14, 2022 · 0 comments
Closed

reviewdog Vale is slower compared to its ancestor #82

nickvigilante opened this issue Oct 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@nickvigilante
Copy link

I'm in the process of upgrading our Vale action to use reviewdog through this PR: cockroachdb/docs#15366

I noticed that while the final results are filtered to display only the files that have an actual diff, the Vale command itself runs against the entire directory and THEN filters. This is considerably slower than it used to be (execution time upwards of 90 seconds).

We really only care about the specific files in the PR (ranging between 1-20 files on average).

I have a workaround of supplying an array of files of the form '["input1", "input2"]', but it was nicer when I used to be able to use __onlyModified without having to implement the workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants