Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch on dynamic HTTP headers in Ktor adapters by default #30

Closed
ermadmi78 opened this issue Oct 7, 2022 · 1 comment
Closed

Switch on dynamic HTTP headers in Ktor adapters by default #30

ermadmi78 opened this issue Oct 7, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ermadmi78
Copy link
Owner

In #26 issue it became possible to switch on dynamic HTTP headers in Ktor adapters. But by default this feature is disabled. It would be great to enable dynamic HTTP headers by default in Kobby 2.0 release.

Attention! It is breaking change!!! To return to previous settings, use:

Gradle:

plugins {
    kotlin("jvm")
    id("io.github.ermadmi78.kobby")
}

kobby {
    kotlin {
        adapter {
            ktor {
                dynamicHttpHeaders = false
            }
        }
    }
}

Maven:

<build>
    <plugins>
        <plugin>
            <groupId>io.github.ermadmi78</groupId>
            <artifactId>kobby-maven-plugin</artifactId>
            <version>1.6.0</version>
            <executions>
                <execution>
                    <phase>generate-sources</phase>
                    <goals>
                        <goal>generate-kotlin</goal>
                    </goals>
                    <configuration>
                        <kotlin>
                            <adapter>
                                <ktor>
                                    <dynamicHttpHeaders>false</dynamicHttpHeaders>
                                </ktor>
                            </adapter>
                        </kotlin>
                    </configuration>
                </execution>
            </executions>
        </plugin>
    </plugins>
</build>
@ermadmi78 ermadmi78 added the enhancement New feature or request label Oct 7, 2022
@ermadmi78 ermadmi78 added this to the Version 2.0 milestone Oct 7, 2022
@ermadmi78 ermadmi78 self-assigned this Oct 7, 2022
@ermadmi78
Copy link
Owner Author

Available since release 2.0.0-beta.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant