Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder structure #176

Merged
merged 6 commits into from
Sep 10, 2015
Merged

Update folder structure #176

merged 6 commits into from
Sep 10, 2015

Conversation

justingreenberg
Copy link
Contributor

Resolves #169

So, this ended up being a pretty big PR. My goals were twofold:
  • Simplify the structure so people using this as a reference can quickly scan through and identify the moving parts or relevant implementations with minimal effort
  • For those using this as a boilerplate, establish well defined contact points between the router, containers and components with maintainable conventions
New ./src directory tree (browse)
./src
├── api
│   └── actions
├── components
│   ├── __tests__
│   ├── CounterButton
│   ├── GithubButton
│   ├── InfoBar
│   ├── MiniInfoBar
│   ├── SurveyForm
│   └── WidgetForm
├── containers
│   ├── __tests__
│   ├── About
│   ├── App
│   ├── Home
│   ├── Login
│   ├── LoginSuccess
│   ├── NotFound
│   ├── RequireLogin
│   ├── Survey
│   └── Widgets
├── helpers
├── redux
│   ├── middleware
│   └── modules
└── utils

If these changes are too drastic, I can just always roll them into a new seed project or something

Known bug: When server-side rendering the /widgets route and the API throws, the router was throwing an error at server.js#L66 and express was responding with a empty JSON object (presumably the failed results). I couldn't identify the cause of this behavior, so right now if the server detects an issue with data fetching during a server-side render, we just sending app and rehydrating store on client.

Any feedback would be greatly appreciated! Thanks again 😃

update js filenames and comments to be more descriptive
…cture

* erikras/master:
  upgraded autoprefixer-loader, upgraded to redux-form 1.5.0
  fixed bug where clientMiddleware was not ever rejecting the promise
  add eslint-loader for linting per webpack dev build
* erikras/master:
  better conditional check on user. #175
  actually upgraded to redux-form 1.5
  fixed bug where login success page was rendering when user was null, before App.js transitioned to home page. fixes #175
karma passing, manually tested in dev/production both with and without
ssr, everything appears to be working
added middleware and moved ducks into modules folder, moved validation
into utils, moved universal helpers into helpers dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants