Updating title using React-Helmet

[tmbtech]

@erikras How do you feel about adding React-Helmet to update titles and meta data? This component would allow developers to update the title/meta tags based on the view.

I'm part of the team that open sourced it. I can PR some code, but I wanted to check with you before I started writing code.

lmk, thanks.

[erikras]

I've been using react-document-meta in my own project. Aside from your personal pride (😀), are there significant benefits to helmet?

[tmbtech]

I personally haven't used react-document-meta.... I'll take it back to the team and find out!

[tmbtech]

It looks like they are pretty similar, the biggest advantage would be hands on support, I can always bubble up any issues to the team. :)

We are using React-Helmet in all of our new react websites, we are also seeking feedback so we can improve on our open source workflow. We plan to release more and the feedback would help tremendously.

[erikras]

Good enough reasons for me. PR away!

[korczis]

So what is the plan with this?

[tmbtech]

I'll issue a PR ASAP.

[tmbtech]

@erikras I just started integrating react-helmet, there are only a few TODO items left. Feel free to take a look at the code. feature/react-helmet

TODO:

• Update Html.js jsdocs
• Update DISABLE_SSR section in server.js
• Refactor / clean up code.
• Address any feedback you have.

(I'm doing this outside of work hours, I'll try to finish it up by thursday / friday)

[andreimc]

👍

[tmbtech]

Sorry, I got slammed at work, I'll have this done tonight.

[codepunkt]

@tmbtech Does react-helmet work with SSR?

[dmitry]

Looks like react-helmet could be used to render on the server side: https://github.com/nfl/react-helmet#server-usage