Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra instances #56

Closed
infinity0 opened this issue Apr 21, 2021 · 5 comments
Closed

extra instances #56

infinity0 opened this issue Apr 21, 2021 · 5 comments

Comments

@infinity0
Copy link

Hi, thanks for creating this package. I needed some extra instances so I went ahead and defined them and uploaded it to hackage: https://hackage.haskell.org/package/wide-word-instances-0.1

If you'd like to merge those into this repo or co-maintain them or something, just let me know, I will be happy to add you to the hackage owners group.

@erikd
Copy link
Owner

erikd commented Apr 21, 2021

I can't see any good reason why these instances should not be provided by wide-word itself. Please submit a PR.

@infinity0
Copy link
Author

I was thinking it might be good to try to have this added to GHC base libraries, e.g. like how rust provides 128 and 256-bit integers. In this case, these instances would have to go in their respective packages binary and serialise.

@phadej
Copy link
Contributor

phadej commented Feb 2, 2023

I think Binary belongs to wide-word (See also #50). serialize OTOH starts to be a heavier package, so it makes more sense for serialise to depend on wide-word, and I don't see a reason why it wouldn't.

@phadej
Copy link
Contributor

phadej commented Feb 2, 2023

To clarify my stance on serialise instances.

I'm considering adding wide-word dependency to e.g. aeson. But if there is even a slightest chance (or risk) that wide-word would depend on serialise, then I cannot afford that.

The current dependency footprint of wide-word is acceptable, but depending on libraries which itself depend on a lot of packages (like serialise is a batteries-included one depending on plenty of small type providing libs) won't be.

@erikd
Copy link
Owner

erikd commented Feb 14, 2023

I will not be adding serialise instances to wide-word.

The binary instance is here: #78

@erikd erikd closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants