Add widening_mul, group absolute value operations, reformat. #1
Conversation
| @@ -31,13 +31,30 @@ impl<const LIMBS: usize> Int<LIMBS> { | |||
|
|
|||
| (lo, hi, negate) | |||
| } | |||
|
|
|||
| /// Multiply `self` by `rhs`, returning a concatenated "wide" result. | |||
| pub const fn widening_mul<const RHS_LIMBS: usize, const WIDE_LIMBS: usize>( | |||
There was a problem hiding this comment.
Now that we have widening_mul, could be nice to implement Mul<Int<RHS_LIMBS>> for Int<LIMBS> similarly to Uint. This was done by me at the time using macros, the idea was for the standard type to have Mul<Int128> for Int192 and such.
|
@lleoha thanks for adding this! It is a great addition 👌 Let's fine-tune the details in the conversations I started. |
|
@lleoha looks good! There are two remarks still open. Could you please fix these? Then I'll merge. Also, I've been so bold to commit a small code change :) |
sure, i'll update it today after business hours CEST. |
done @erik-3milabs |
@erik-3milabs
I also did some changes, please review and incorporate in yours if you will.
What I did is:
num_traits::signed,