Skip to content

Commit

Permalink
Docker build: make db-tools to depend on git-submodules (#4024)
Browse files Browse the repository at this point in the history
* save

* save

* save

* save

* save
  • Loading branch information
AskAlexSharov authored Apr 29, 2022
1 parent 285c782 commit 38e8706
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 1 addition & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ RUN apk --no-cache add make gcc g++ linux-headers git bash ca-certificates libgc
WORKDIR /app
ADD . .

# expect that host run `git submodule update --init`
RUN make erigon rpcdaemon integration sentry txpool downloader hack db-tools
RUN make erigon rpcdaemon integration sentry txpool downloader hack observer db-tools

FROM docker.io/library/alpine:3.15

Expand Down
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ go-version:
exit 1 ;\
fi

docker:
docker: git-submodules
DOCKER_BUILDKIT=1 docker build -t erigon:latest --build-arg git_commit='${GIT_COMMIT}' --build-arg git_branch='${GIT_BRANCH}' --build-arg git_tag='${GIT_TAG}' .

xdg_data_home := ~/.local/share
Expand Down Expand Up @@ -74,7 +74,7 @@ $(COMMANDS): %: %.cmd

all: erigon $(COMMANDS)

db-tools:
db-tools: git-submodules
@echo "Building db-tools"

# hub.docker.com setup incorrect gitpath for git modules. Just remove it and re-init submodule.
Expand Down Expand Up @@ -137,6 +137,7 @@ escape:
cd $(path) && go test -gcflags "-m -m" -run none -bench=BenchmarkJumpdest* -benchmem -memprofile mem.out

git-submodules:
@[ -d ".git" ] || (echo "Not a git repository" && exit 1)
@echo "Updating git submodules"
@# Dockerhub using ./hooks/post-checkout to set submodules, so this line will fail on Dockerhub
@git submodule update --quiet --init --recursive --force || true

0 comments on commit 38e8706

Please sign in to comment.