From e37ccf8b86dbf0861a210b4304c2297b4cc8a931 Mon Sep 17 00:00:00 2001 From: Alexis Menard Date: Wed, 21 Aug 2024 17:07:11 +0000 Subject: [PATCH] Bug 1914051 [wpt PR 47696] - [Viewport Segments] Per CSS WG resolution move the JavaScript segment property from window.visualViewport to the newly added window.viewport., a=testonly Automatic update from web-platform-tests [Viewport Segments] Per CSS WG resolution move the JavaScript segment property from window.visualViewport to the newly added window.viewport. See https://github.com/w3c/csswg-drafts/issues/9237#issuecomment-2160730855 for the full IRC log of the conversation. https://github.com/w3c/csswg-drafts/pull/10564 is the PR adding the segments property part of the CSS Viewport Level 1 specification. There is no functional changes in how the segments property works, tests are updated to reflect the new position. Right now the viewport object is tied to the runtime flag of Viewport Segments because we expect the feature to ship before the viewport attribute receive more fields. Bug: 40113439 Change-Id: Ic0624314ee4300899e9e6e98f009e0b4f1fe9655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783999 Commit-Queue: Alexis Menard Reviewed-by: Reilly Grant Reviewed-by: Chris Harrelson Cr-Commit-Position: refs/heads/main@{#1344484} -- wpt-commits: 9f659d69e19db662afbe89a0b9d056eb1c5fa0f4 wpt-pr: 47696 --- testing/web-platform/tests/viewport/META.yml | 4 ++++ .../web-platform/tests/viewport/WEB_FEATURES.yml | 3 +++ .../tests/viewport/viewport-segments.html | 14 ++++++++++++++ .../viewport-segments.tentative.html | 15 --------------- 4 files changed, 21 insertions(+), 15 deletions(-) create mode 100644 testing/web-platform/tests/viewport/META.yml create mode 100644 testing/web-platform/tests/viewport/WEB_FEATURES.yml create mode 100644 testing/web-platform/tests/viewport/viewport-segments.html delete mode 100644 testing/web-platform/tests/visual-viewport/viewport-segments.tentative.html diff --git a/testing/web-platform/tests/viewport/META.yml b/testing/web-platform/tests/viewport/META.yml new file mode 100644 index 0000000000000..38eb8c0cb93a2 --- /dev/null +++ b/testing/web-platform/tests/viewport/META.yml @@ -0,0 +1,4 @@ +spec: https://drafts.csswg.org/css-viewport-1/ +suggested_reviewers: + - bokand + - chrishtr diff --git a/testing/web-platform/tests/viewport/WEB_FEATURES.yml b/testing/web-platform/tests/viewport/WEB_FEATURES.yml new file mode 100644 index 0000000000000..8f93ba9790f5a --- /dev/null +++ b/testing/web-platform/tests/viewport/WEB_FEATURES.yml @@ -0,0 +1,3 @@ +features: +- name: viewport + files: "**" diff --git a/testing/web-platform/tests/viewport/viewport-segments.html b/testing/web-platform/tests/viewport/viewport-segments.html new file mode 100644 index 0000000000000..64f0eb9caefb0 --- /dev/null +++ b/testing/web-platform/tests/viewport/viewport-segments.html @@ -0,0 +1,14 @@ + + +Viewport Segments: viewport.segments + + + + diff --git a/testing/web-platform/tests/visual-viewport/viewport-segments.tentative.html b/testing/web-platform/tests/visual-viewport/viewport-segments.tentative.html deleted file mode 100644 index c90ed29d730db..0000000000000 --- a/testing/web-platform/tests/visual-viewport/viewport-segments.tentative.html +++ /dev/null @@ -1,15 +0,0 @@ - - -Viewport Segments: visualViewport.segments tentative - - - - -