Recursive analysis not working on Windows 10

[ericcornelissen]

Bug Report

This is a bug report for:

• goparamcount
• goreturncount

More specifically:

• Tool version: v1.0.1 (for both)
• Operating system: Windows 10

Description

The "./..." notation does not seem to work on Windows 10 (and likely other Windows versions)

Actual Behaviour

When using the "./..." notation to recursively inspect a directory on Windows 10 (and possibly other versions) the directory will be inspected non-recursively.

Expected Behaviour

When using the "./..." notation to recursively inspect a directory it should ALWAYS inspect the directory recursively.

Working Example

In gofunchecks tools it can be reproduced on a Windows 10 machine by simply running [TOOL] -max 0 ./... in the gofunchecks directory and you will observe that no errors are reported.

Log Output

n/a

[ericcornelissen]

This seems to be related to an upstream issue in the core Go packages that causes the filepath.Abs() call to remove it from the provided path (on Windows but not on Unix). I filed a report in the official Go repository for this: golang/go#42362. In the meantime I will try to get a temporary fix out for this as soon as possible.

[ericcornelissen]

In the meantime I will try to get a temporary fix out for this as soon as possible.

I was able to find a solution that isn't necessarily temporary, the fix in #3 can stay even if golang/go#42362 is resolved.