Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select boxes #2

Closed
ericclemmons opened this issue Dec 18, 2012 · 4 comments
Closed

Select boxes #2

ericclemmons opened this issue Dec 18, 2012 · 4 comments

Comments

@ericclemmons
Copy link
Owner

When tracking change events on a <select />, it would be nice to indicate what the value is of the select.

@ericclemmons
Copy link
Owner Author

@ronkorving
Copy link
Collaborator

So why didn't you use :checked?
The problem with the current approach is that password values are put in a querySelector string. Are you sure this makes sense? (It definitely doesn't for my use cases). Perhaps it can be suppressed when the tagName is password?

@ericclemmons
Copy link
Owner Author

Can you recreate this as an issue? The use-case was for tracking which item was selected, so you could copy-paste the selector in the same page yourself & re-produce what the user saw/clicked/etc.

The password example makes sense. I think there are different selectors that make sense for different tags.

@ronkorving
Copy link
Collaborator

I can see where it makes sense. And a value is more readable than an nth-child. I'm just worried about those cases where value is user input (textarea, text, password, and all the new types like email, etc). I'll open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants