Could not select candidate in pager mode

[YangchenYe323]

Hi team, I'm looking to support a paged tab completion for an application I'm building using readline.

I noticed that currently the user cannot select or navigate the candidates in pager mode, which makes it less useful. In chyzer#238 I treated paging as a transparent feature. I did not give it an explicit mode, so the user could navigate as usual in CompletSelection mode with added hotkeys for scrolling through the page.

Below is a demo of what my implementation looks like:

I'd be happy to submit a PR if this change is welcome, or if there are plans to support selecting in pager mode I'd be happy to hack something that aligns with your preferred design, too.

[slingamn]

Hi, this sounds interesting, but I wanted to clarify what you mean by "currently the user cannot select or navigate the candidates in pager mode". If you go run example/readline-demo/readline-demo.go and press the Tab key once, you should see a list of completion options. If you press it a second time, the first option should be visibly selected (as in your demo), and Tab/Shift-Tab and Right/Left should navigate through the options, with Enter choosing the selected option. I can believe that the existing implementation does not scale to the use case you described (~1000 options) but I would like to understand more about what you are proposing to add, and how it differs from what we currently have implemented.

[YangchenYe323]

Hi. thanks for your reply.

I can believe that the existing implementation does not scale to the use case you described (~1000 options)

The existing implementation will fall back to pager mode when the number of candidates cannot be shown on a single screen, which looks like this:

And in this mode the user could not select the candidate by pressing another Tab or navigating using the arrow keys. I believe this is because the input is intercepted in the HandlePagerMode method, and the mode does not support selecting a candidate from the page.

I would like to understand more about what you are proposing to add, and how it differs from what we currently have implemented.

I think it would be nice to support selecting candidate in the pager mode like I show in my demo, where the user could both navigate the page and use Tab/arrow/enters to select a candidate to put on the buffer.

[slingamn]

Oh, now I understand. Yes, a PR for this would be very welcome! Thanks.