Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: "You're connected" indicator #5

Closed
lopcode opened this issue Dec 29, 2017 · 5 comments
Closed

Feature request: "You're connected" indicator #5

lopcode opened this issue Dec 29, 2017 · 5 comments

Comments

@lopcode
Copy link

lopcode commented Dec 29, 2017

I'm testing Burrow, and noticed that there's no indication that you're connected. I think most servers send you something like "Looking up your hostname" messages which makes it more obvious.

A little message saying you're connected might be helpful. I've attached a screenshot of a successful connection to a testnet, with no messages.

screen shot 2017-12-29 at 12 30 37

@DanielOaks
Copy link
Member

Hmm, this is an interesting one for sure. I think waiting for just a moment and then displaying our own "Connected!" message if none comes from the server would work pretty decently. Kinda wanna keep ircdog relatively light, always printing a Connected! message feels a little strange.

I'll play around with it, might not be that bad once I try it out for realsies. Thanks very much for the suggestion!

@slingamn
Copy link
Member

slingamn commented Feb 6, 2023

If we get readline support (#28), the prompt won't display until we successfully connect to the remote, which will help somewhat.

We might also consider a verbose mode (compare netcat).

@jesopo
Copy link
Contributor

jesopo commented Feb 6, 2023

for reference, netcat's behaviour:

✨ ~ % nc irc.libera.chat 6667
:cadmium.libera.chat NOTICE * :*** Checking Ident
:cadmium.libera.chat NOTICE * :*** Looking up your hostname...
:cadmium.libera.chat NOTICE * :*** Found your hostname: husky.lolnerd.net
^C
✨ ~ % nc irc.libera.chat 6667 -v
Connection to irc.libera.chat (2001:470:1:dea::95) 6667 port [tcp/ircd] succeeded!
:cadmium.libera.chat NOTICE * :*** Checking Ident
:cadmium.libera.chat NOTICE * :*** Looking up your hostname...
:cadmium.libera.chat NOTICE * :*** Found your hostname: husky.lolnerd.net

@slingamn
Copy link
Member

slingamn commented Feb 6, 2023

Yeah, that's similar to what we print unconditionally in --listen mode:

log.Printf("** ircdog connected to remote at %s", server.RemoteAddr().String())

I'm sold, let's get a verbose mode.

@slingamn
Copy link
Member

slingamn commented Feb 7, 2023

Added --verbose in 8e33735

@slingamn slingamn closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants