Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes in single level namespace not resovled correctly for PHP 8 #326

Closed
abenerd opened this issue Jan 9, 2021 · 2 comments · Fixed by #343
Closed

Classes in single level namespace not resovled correctly for PHP 8 #326

abenerd opened this issue Jan 9, 2021 · 2 comments · Fixed by #343
Assignees
@localheinz
Labels
bug

Comments

@abenerd
Copy link

abenerd commented Jan 9, 2021

Steps required to reproduce the problem

  1. Run PHP 8
  2. Have class with single level namespace such as App
  3. Try to resolve using Constructs::fromDirectory($directory)
  4. Check Construct name

Example Repo is under: https://github.com/abenettt/classy-namespace-error

Expected Result

  • FQCN to be resolved correctly and tests to pass

Actual Result

  • FQCN is resolved as name of the file so the test fails
@localheinz localheinz self-assigned this Jan 30, 2021
@localheinz localheinz added the bug label Jan 30, 2021
@localheinz
Copy link
Member

Thank you for reporting, @abenettt!

Will take a look!

This was referenced Feb 1, 2021
Merged
Merged
@localheinz
Copy link
Member

localheinz commented Feb 1, 2021 •
edited
Loading

@abenettt

Released as ergebnis/classy:1.1.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Properly determine classy name within namespace with single segment ergebnis/classy
2 participants
@localheinz @abenerd