Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SublimeLinter3 colors #880

Closed
glebec opened this issue Jun 20, 2016 · 2 comments
Closed

Support SublimeLinter3 colors #880

glebec opened this issue Jun 20, 2016 · 2 comments

Comments

@glebec
Copy link

glebec commented Jun 20, 2016

In the most recent release of Material, the new color scheme doesn't play nicely with SublimeLinter3 for some reason — error marks in the gutter appear white instead of red. In theory, SublimeLinter should patch and write copies of color schemes (appended with SL) and switch to that scheme; this happens correctly for all other color schemes I have tried, but for some reason I haven't yet figured it out, it fails to occur correctly with Material.

While this is more of a SublimeLinter3 issue than a Material issue, and I will likely be opening an issue there, the good news is that Material itself can solve the issue by including certain defined colors. See https://sublimelinter.readthedocs.io/en/latest/usage.html#choosing-color-schemes for a little more info. However I understand if you're less than thrilled with including arbitrary color names from different packages that have nothing to do with Material per se.

@glebec
Copy link
Author

glebec commented Jun 20, 2016

It looks like this is the culprit — I am not 100% clear on the proper way to format SublimeLinter color fields, will compare & contrast with other schemes. Seems odd to me that an explicit fix commit would introduce an incompatibility with SublimeLinter3 — maybe I am missing something?

d2c5cf1#diff-555f281cef4f5185134e89f7e8eae2daR392

@glebec
Copy link
Author

glebec commented Jun 20, 2016

Confirmed — changing it back to only foreground, with the red color, gives the expected red marks. I could write a PR but I'd want to research more and understand precisely how SublimeLinter expects these key-val pairs to be set up, especially since you already changed it once in the other direction. I'll therefore hold off on making the PR until you either confirm or deny that it is "supposed" to have foreground white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant