Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown syntax highlighting issues after 4.0.1 #1027

Closed
1 task done
kaspersoerensen opened this issue Nov 4, 2016 · 3 comments
Closed
1 task done

Markdown syntax highlighting issues after 4.0.1 #1027

kaspersoerensen opened this issue Nov 4, 2016 · 3 comments

Comments

@kaspersoerensen
Copy link

Summary

After updating to 4.0.1 and not having the old themes longer, my markdown syntax highlighting seems to be off (or maybe I just can't seem to figure out how to config it).

These two screen dumps should describe the issues I am having:

Right margin "overflow":

skaermbillede 2016-11-04 kl 11 35 00

Incorrects coloring of tags in the XML code
skaermbillede 2016-11-04 kl 11 35 08

Settings (Syntax-specific)

{
	"draw_centered": true,
    "draw_indent_guides": false,
    "trim_trailing_white_space_on_save": false,
    "word_wrap": true,
    "wrap_width": 80,
}

Settings

{
	"always_show_minimap_viewport": "true",
	"auto_complete_commit_on_tab": "true",
	"bold_folder_labels": "true",
	"color_scheme": "Packages/Material Theme/schemes/Material-Theme.tmTheme",
	"dictionary": "Packages/Language - English/en_US.dic",
	"ignored_packages":
	[
		"Vintage"
	],
	"indent_guide_options":
	[
		"draw_normal",
		"draw_active"
	],
	"line_padding_bottom": 3,
	"line_padding_top": 3,
	"material_theme_bold_tab": "true",
	"material_theme_compact_sidebar": "true",
	"material_theme_small_statusbar": "true",
	"material_theme_small_tab": "true",
	"material_theme_tree_headings": true,
	"overlay_scroll_bars": "enabled",
	"spell_check": "true",
	"theme": "Material-Theme.sublime-theme"
}

Environment

  • Operating system and version:
    • Mac OS 10.11.4
  • Sublime Text:
    • Build 3126
  • Material Theme release:
    • v 4.0.1

Side node

IMO - the colors from the old theme looked a lot cleaner than the new ones.

@equinusocio
Copy link
Member

Can you paste the xml snippet?

@kaspersoerensen
Copy link
Author

Yes:

<?xml version="1.0" encoding="UTF-8"?>
<Settings>
    <ControlData> </ControlData>
    <CRTData> </CRTData>
    <DICOMData> </DICOMData>
    <CursorData> </CursorData>
    <SportPre> </SportPre>
    <SportPost> </SportPost>
</Settings>

@equinusocio
Copy link
Member

equinusocio commented Nov 7, 2016

I fixed the markdown raw code background color. The xml issue is caused by the markdown package because it provide two different scopes for the tags, Check this screenshots:

screen shot 2016-11-07 at 18 33 17

screen shot 2016-11-07 at 18 33 24

In this example you can notice that the <plist> tag have the right color, that's because the markdown package provide the same scope for both tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants