Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a filter for table columns in modals should not add the filter as search params🐛 #2530

Open
eliasbruvik opened this issue Aug 23, 2024 · 0 comments
Labels
Bug Something isn't working Javascript Pull requests that update Javascript code

Comments

@eliasbruvik
Copy link
Contributor

Functionality for the tables is made generic to avoid having to implement it for every location the table is used. Among these functionalities is adding a filter to the table by specifying a value in the input field next to a column in the filter menu:

image

The example above is from the table as provided by the result of the Missing Data Agent (available by right-clicking on one more several wells or wellbores).

This works as expected in most cases. However, it should not add the filter to the search params, OR use any filter specified in the search params if the table is shown in a modal. The search params should only be used for the main tables.

This is currently added even for modal tables.
image

The filter is edited and applied in columnOptionsMenu.tsx.

@eliasbruvik eliasbruvik added Bug Something isn't working Javascript Pull requests that update Javascript code labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

2 participants