Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sign desktop edition #2400

Open
janmarius opened this issue May 3, 2024 · 3 comments
Open

Code sign desktop edition #2400

janmarius opened this issue May 3, 2024 · 3 comments
Labels
Desktop Requires specific updates to the Desktop app Needs grooming

Comments

@janmarius
Copy link
Contributor

We aim to code sign the desktop edition for general users, not just for specific companies like Equinor.

@eliasbruvik eliasbruvik self-assigned this May 3, 2024
@eliasbruvik eliasbruvik added the Desktop Requires specific updates to the Desktop app label May 21, 2024
@eliasbruvik eliasbruvik removed their assignment Jun 10, 2024
@eliasbruvik
Copy link
Contributor

As it should be code signed for general users and not just Equinor's users, we can't use Equinor's internal service for code-signing.

It has also been discussed whether or not we need to code-sign it. For now it seems that users are able to run the installer, but they get a warning saying that the application can be harmful. This is normal for apps that are not code-signed.

If we want to code-sign it, these points needs to be answered:

  • Does Equinor have agreements or restrictions on which certificate providers we can use?
  • The certificate must be installed/stored on hardware tokens or HSMs that are then used in the signing process. Are there any restrictions around this?

@eliasbruvik
Copy link
Contributor

Removing High Priority as nobody has come forward with any problems getting around the warning yet.

@robertbasti
Copy link
Collaborator

wait for some use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Desktop Requires specific updates to the Desktop app Needs grooming
Projects
None yet
Development

No branches or pull requests

3 participants