Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable app logs and diagnostics #40

Merged
merged 8 commits into from
Nov 10, 2022
Merged

feat!: enable app logs and diagnostics #40

merged 8 commits into from
Nov 10, 2022

Conversation

helenakallekleiv
Copy link
Contributor

@helenakallekleiv helenakallekleiv commented Sep 22, 2022

Enable application logs for Azure Web App, and send diagnostics to Azure Monitor.

Closes #37, closes #18

@helenakallekleiv
Copy link
Contributor Author

Go tests passed on my local machine.

@hknutsen
Copy link
Member

hknutsen commented Nov 8, 2022

Consider enabling app logs as well.

@hknutsen hknutsen changed the title feat: add diagnostic setting feat!: enable app logs and diagnostics Nov 8, 2022
@hknutsen hknutsen marked this pull request as ready for review November 8, 2022 13:49
@hknutsen hknutsen requested a review from a team November 8, 2022 13:50
@helenakallekleiv
Copy link
Contributor Author

helenakallekleiv commented Nov 9, 2022

Go test passed on my local machine for all examples (container, windows and linux).

I am listed as the author of this PR, and can't give a review.

Copy link
Contributor

@sebastianlolv sebastianlolv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes tests on my machine too.

@hknutsen hknutsen merged commit 8d34a07 into main Nov 10, 2022
@hknutsen hknutsen deleted the diagnostic-setting branch November 10, 2022 07:21
@github-actions
Copy link
Contributor

🎉 This PR is included in version 9.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add diagnostic setting
3 participants