Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: simplify auth settings #27

Merged
merged 8 commits into from
Aug 3, 2022
Merged

Conversation

hknutsen
Copy link
Member

@hknutsen hknutsen commented Aug 3, 2022

Reduce number of input variables required to setup Azure AD authentication.

BREAKING CHANGE: variable app_service_settings removed

BREAKING CHANGE: variable azuread_client_id renamed to aad_client_id

BREAKING CHANGE: variable key_vault_name removed

BREAKING CHANGE: variable key_vault_secret_name removed

@hknutsen hknutsen added the enhancement New feature or request label Aug 3, 2022
@hknutsen hknutsen self-assigned this Aug 3, 2022
@hknutsen hknutsen requested a review from sebastianlolv August 3, 2022 12:25
variables.tf Outdated Show resolved Hide resolved
@hknutsen hknutsen marked this pull request as ready for review August 3, 2022 12:33
@hknutsen hknutsen merged commit 3b26848 into main Aug 3, 2022
@hknutsen hknutsen deleted the feat/simplify-auth-settings branch August 3, 2022 17:54
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants