Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure virtual applications #224

Merged
merged 18 commits into from
Feb 5, 2025
Merged

feat: configure virtual applications #224

merged 18 commits into from
Feb 5, 2025

Conversation

sebastianlolv
Copy link
Contributor

@sebastianlolv sebastianlolv commented Jan 22, 2025

Created a variable for settings virtual app path mappings for windows web apps. Virtual Application doesn't exist for Linux web apps.

There is an issue when importing existing windows web apps with virtual application set it will try to delete a set virtual application.

Please contribute if this is the wrong way or I'm missing something.

@sebastianlolv sebastianlolv requested a review from a team as a code owner January 22, 2025 10:36
@sebastianlolv sebastianlolv changed the title feat: create variable for virtual application path mappings feat: create variable for virtual application path mappings for window web app Jan 22, 2025
@sebastianlolv sebastianlolv self-assigned this Jan 22, 2025
@sebastianlolv sebastianlolv added the enhancement New feature or request label Jan 22, 2025
@sebastianlolv sebastianlolv changed the title feat: create variable for virtual application path mappings for window web app feat: create variable for virtual application path mappings for windows web app Jan 22, 2025
@hknutsen
Copy link
Member

According to the Azure provider docs for resource azurerm_windows_web_app, there can be one or more virtual_application blocks: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/windows_web_app#virtual_application-1

Thus:

  • Variable virtual_application (singular) should be renamed to virtual_applications (plural).
  • Variable virtual_applications should be of type list(object) (ref.).

variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@hknutsen hknutsen changed the title feat: create variable for virtual application path mappings for windows web app feat: configure virtual applications Feb 5, 2025
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
sebastianlolv and others added 3 commits February 5, 2025 12:53
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
main.tf Outdated Show resolved Hide resolved
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
@sebastianlolv sebastianlolv merged commit 2b1ca35 into main Feb 5, 2025
1 check passed
@sebastianlolv sebastianlolv deleted the virtual-app branch February 5, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants