Remove hard-coded observation uncertainties

[anders-kiaer]

Observation uncertainties are currently hard-coded:

flownet/src/flownet/templates/observations.ertobs.jinja2

Lines 11 to 42 in 038256c

	{%- if not isnan(kw.oil_rate): -%}
	SUMMARY_OBSERVATION WOPR_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.oil_rate }}; ERROR = {{ [0.1 * kw.oil_rate, 50] | max }}; DATE = {{ date_formatted }}; KEY = WOPR:{{ kw.well_name }}; };
	{%- endif %}
	{%- if not isnan(kw.gas_rate): %}
	SUMMARY_OBSERVATION WGPR_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.gas_rate }}; ERROR = {{ [0.1 * kw.gas_rate, 100000] | max }}; DATE = {{ date_formatted }}; KEY = WGPR:{{ kw.well_name }}; };
	{%- endif %}
	{%- if not isnan(kw.bhp): %}
	SUMMARY_OBSERVATION WBHP_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.bhp }}; ERROR = {{ [0.05 * kw.bhp, 10] | max }}; DATE = {{ date_formatted }}; KEY = WBHP:{{ kw.well_name }}; };
	{%- endif %}
	{%- if not isnan(kw.thp): %}
	SUMMARY_OBSERVATION WTHP_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.thp }}; ERROR = {{ [0.05 * kw.thp, 5] | max }}; DATE = {{ date_formatted }}; KEY = WTHP:{{ kw.well_name }}; };
	{%- endif %}
	{%- endif %}
	{% endfor %}
	{%- endif %}
	{%- if schedule.get_keywords(date=date, kw_class="WCONINJH"): %}
	{%- for kw in schedule.get_keywords(date=date, kw_class="WCONINJH"): -%}
	{%- if not schedule.get_well_start_date(kw.well_name) == date: %}
	{%- set index_name = date.strftime('%d_%m_%Y') -%}
	{%- set date_formatted = date.strftime('%d/%m/%Y') %}
	{%- if not isnan(kw.bhp): %}
	SUMMARY_OBSERVATION WBHP_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.bhp }}; ERROR = {{ [0.05 * kw.bhp, 10] | max }}; DATE = {{ date_formatted }}; KEY = WBHP:{{ kw.well_name }}; };
	{%- endif %}
	{%- if not isnan(kw.thp): %}
	SUMMARY_OBSERVATION WTHP_{{ kw.well_name }}_{{ index_name }} { VALUE = {{ kw.thp }}; ERROR = {{ [0.05 * kw.thp, 5] | max }}; DATE = {{ date_formatted }}; KEY = WTHP:{{ kw.well_name }}; };
	{%- endif %}

flownet/src/flownet/templates/observations.yamlobs.jinja2

Lines 10 to 73 in 038256c

	error: {{ [0.1 * kw.oil_rate, 50] | max }}
	{%- endif -%}
	{%- endfor %}
	{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="gas_rate") -%}
	{% if loop.first and not loop.last: %}
	- key: WGPR:{{ well_name }}
	observations:
	{%- elif not loop.first: %}
	- date: {{ kw.date.strftime('%Y-%m-%d') }}
	value: {{ kw.gas_rate }}
	error: {{ [0.1 * kw.gas_rate, 100000] | max }}
	{%- endif -%}
	{%- endfor %}
	{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="water_rate") -%}
	{% if loop.first and not loop.last: %}
	- key: WWPR:{{ well_name }}
	observations:
	{%- elif not loop.first: %}
	- date: {{ kw.date.strftime('%Y-%m-%d') }}
	value: {{ kw.water_rate }}
	error: {{ [0.1 * kw.water_rate, 50] | max }}
	{%- endif -%}
	{%- endfor %}
	{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="bhp") -%}
	{% if loop.first and not loop.last: %}
	- key: WBHP:{{ well_name }}
	observations:
	{%- elif not loop.first: %}
	- date: {{ kw.date.strftime('%Y-%m-%d') }}
	value: {{ kw.bhp }}
	error: {{ [0.05 * kw.bhp, 10] | max }}
	{%- endif -%}
	{%- endfor %}
	{%- for kw in schedule.get_keywords(kw_class="WCONHIST", well_name=well_name, ignore_nan="thp") -%}
	{% if loop.first and not loop.last: %}
	- key: WTHP:{{ well_name }}
	observations:
	{%- elif not loop.first: %}
	- date: {{ kw.date.strftime('%Y-%m-%d') }}
	value: {{ kw.thp }}
	error: {{ [0.05 * kw.thp, 5] | max }}
	{%- endif -%}
	{%- endfor %}
	{%- endfor -%}
	{% for well_name in schedule.get_wells(kw_class="WCONINJH") %}
	{%- for kw in schedule.get_keywords(kw_class="WCONINJH", well_name=well_name, ignore_nan="bhp") -%}
	{% if loop.first and not loop.last: %}
	- key: WBHP:{{ well_name }}
	observations:
	{%- elif not loop.first: %}
	- date: {{ kw.date.strftime('%Y-%m-%d') }}
	value: {{ kw.bhp }}
	error: {{ [0.05 * kw.bhp, 10] | max }}
	{%- endif -%}
	{%- endfor %}
	{%- for kw in schedule.get_keywords(kw_class="WCONINJH", well_name=well_name, ignore_nan="thp") -%}
	{% if loop.first and not loop.last: %}
	- key: WTHP:{{ well_name }}
	observations:
	{%- elif not loop.first: %}
	- date: {{ kw.date.strftime('%Y-%m-%d') }}
	value: {{ kw.bhp }}
	error: {{ [0.05 * kw.thp, 5] | max }}

The user should have ownership to these (at least as long as observations and uncertainties are not extracted automatically from raw data in some future). Maybe the currently hard-coded values (both % and min. absolute value) should be moved to config, with no default value?

[wouterjdb]

Suggestion from stand-up:

name: Norne

flownet:
  data_source:
    simulation:
      input_case: ../tests/data/norne/NORNE_ATW2013
      vectors:
        WTHP:            
          min_error: 10
          rel_error: 50%
        WBHP:
          min_error: 10
          rel_error: 50%
        FOPR:
         
          
  phases:
    - oil
    - gas
    - vapoil
    - disgas
    - water
  pvt: