Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging of cpu-seconds will miss subprocesses that exit before the main process #9941

Open
berland opened this issue Feb 3, 2025 · 1 comment · May be fixed by #9943
Open

Logging of cpu-seconds will miss subprocesses that exit before the main process #9941

berland opened this issue Feb 3, 2025 · 1 comment · May be fixed by #9943
Assignees
Labels

Comments

@berland
Copy link
Contributor

berland commented Feb 3, 2025

The polling nature of cpu-seconds counting in

(memory_rss, cpu_seconds, oom_score, pids) = _get_processtree_data(process)

will underestimate the cpu_seconds if the main process for the forward model step launches subprocesses that end earlier than the main process, as the process tree for a process that has ended does not exist in the kernel any longer.

@berland berland linked a pull request Feb 3, 2025 that will close this issue
9 tasks
@berland berland changed the title Logging of cpu-seconds will miss subprocesses that exits before the main process Logging of cpu-seconds will miss subprocesses that exit before the main process Feb 3, 2025
@sondreso sondreso added the bug label Feb 3, 2025
@sondreso sondreso moved this to Todo in SCOUT Feb 3, 2025
@berland
Copy link
Contributor Author

berland commented Feb 3, 2025

It is probable that this happens for the RMS step, as it is known to launch subprocesses for parts of its doing.

@berland berland moved this from Todo to Ready for Review in SCOUT Feb 3, 2025
@berland berland moved this from Ready for Review to In Progress in SCOUT Feb 3, 2025
@berland berland moved this from In Progress to Ready for Review in SCOUT Feb 3, 2025
@berland berland self-assigned this Feb 3, 2025
@eivindjahren eivindjahren moved this from Ready for Review to Reviewed in SCOUT Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Reviewed
Development

Successfully merging a pull request may close this issue.

2 participants