From 0c4c3c27e64122c703134670ac98f576fdcdea73 Mon Sep 17 00:00:00 2001 From: Jonathan Karlsen Date: Tue, 4 Feb 2025 12:10:59 +0100 Subject: [PATCH] Fix workflows running from gui's tools panel not working This commit fixes the issue where most of the legacy workflows would not work due to ert_config not being passed to workflow_runner in run_workflow_widget. --- src/ert/gui/tools/plugins/plugin_runner.py | 3 +-- src/ert/gui/tools/workflows/run_workflow_widget.py | 1 + src/ert/workflow_runner.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ert/gui/tools/plugins/plugin_runner.py b/src/ert/gui/tools/plugins/plugin_runner.py index 1fea02f6edc..965c13f372e 100644 --- a/src/ert/gui/tools/plugins/plugin_runner.py +++ b/src/ert/gui/tools/plugins/plugin_runner.py @@ -35,7 +35,6 @@ def __init__( def run(self) -> None: try: plugin = self.__plugin - arguments = plugin.getArguments( fixtures={"storage": self.storage, "ert_config": self.ert_config} ) @@ -46,7 +45,7 @@ def run(self) -> None: fixtures = { k: getattr(self, k) for k in ["storage", "ert_config"] - if getattr(self, k) + if hasattr(self, k) } workflow_job_thread = ErtThread( name="ert_gui_workflow_job_thread", diff --git a/src/ert/gui/tools/workflows/run_workflow_widget.py b/src/ert/gui/tools/workflows/run_workflow_widget.py index 2fe3157f2c7..81eecdc160e 100644 --- a/src/ert/gui/tools/workflows/run_workflow_widget.py +++ b/src/ert/gui/tools/workflows/run_workflow_widget.py @@ -128,6 +128,7 @@ def startWorkflow(self) -> None: workflow, storage=self.storage, ensemble=self.source_ensemble_selector.currentData(), + ert_config=self.config, ) self._workflow_runner.run() diff --git a/src/ert/workflow_runner.py b/src/ert/workflow_runner.py index 232ed13a8f9..c02092d3d58 100644 --- a/src/ert/workflow_runner.py +++ b/src/ert/workflow_runner.py @@ -153,7 +153,7 @@ def run_blocking(self) -> None: fixtures = { k: getattr(self, k) for k in ["storage", "ensemble", "ert_config"] - if getattr(self, k) + if hasattr(self, k) } for job, args in self.__workflow: