Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce linting during builds #428

Closed
wenche opened this issue Aug 20, 2021 · 1 comment
Closed

Reintroduce linting during builds #428

wenche opened this issue Aug 20, 2021 · 1 comment
Labels
🌐 Next.js (web) 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@wenche
Copy link
Contributor

wenche commented Aug 20, 2021 •
edited
Loading

We had to disable linting during builds because of issues with Next.js new linting features, monorepos and excisting lint configuration.

Check if this issue will fix it.

Also see https://sanity-io-land.slack.com/archives/C013NG0UF0B/p1624354835143700
@wenche wenche added 🌐 Next.js (web) 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base labels Aug 20, 2021
@wenche
Copy link
Contributor Author

wenche commented Aug 20, 2021

It seems like the original issue is fixed. But our monorepo is still causing a lot of issues with the path inside the web folder. Let's stick with the linting as a separate task and still disable it during builds. Sigh.

@wenche wenche closed this as completed Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌐 Next.js (web) 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wenche