Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal components Label and Input available as building blocks #960

Closed
wenche opened this issue Dec 8, 2020 · 0 comments
Closed
Labels
core-react eds-core-react 💡 feature request 🔨 technical Technical debt and similar

Comments

@wenche
Copy link
Contributor

wenche commented Dec 8, 2020

In <Select> and <MultiSelect> we use the hooks from Downshift with Input, Label, Button and List to create the components.

For EDS users with more advanced or specific use cases for select it will probably be easier to make all these components available and let the user combine them with hooks in their project.

Input and Label is internal components, and are not exported as a part of EDS today. It's also quite a lot of styles for especially the options list using List and ListItem components. We should probably align this with the Paper component if possible or export the styled version as an OptionsList or something like that.

We also need this to be documented somehow for developers. Perhaps add a "hooks" headline in the storybook? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-react eds-core-react 💡 feature request 🔨 technical Technical debt and similar
Projects
None yet
Development

No branches or pull requests

2 participants