Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Select All option in Autocomplete component disappears on scroll #3655

Open
magnh opened this issue Oct 14, 2024 · 2 comments
Open

🐛 Select All option in Autocomplete component disappears on scroll #3655

magnh opened this issue Oct 14, 2024 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@magnh
Copy link
Contributor

magnh commented Oct 14, 2024

Describe the bug

When you have 30 items or more, the Select All option disappears when scrolling. I assume the issues is caused by useVirtualizer removing the option.

https://codesandbox.io/p/sandbox/eds-autocomplete-select-all-disappearing-xrn9qm

Steps to reproduce the bug

  1. Open https://codesandbox.io/p/sandbox/eds-autocomplete-select-all-disappearing-xrn9qm
  2. Scroll far down
  3. See the Select All option disappear

Expected behavior

It should not disappear.

Specifications

  • Version: 0.39.0
  • Browser: N/A
  • OS: N/A

Additional context

https://codesandbox.io/p/sandbox/eds-autocomplete-select-all-disappearing-xrn9qm

@magnh magnh added the 🐛 bug Something isn't working label Oct 14, 2024
@oddvernes
Copy link
Collaborator

This makes sense as the select all "item" is injected into the rest of the options and handled by the virtualizer. I remember @yusijs tried a bunch of stuff and this was the solution that played nice with the virtualizer. We'll have to take another look if there is something we can do here about this 👍

@magnh
Copy link
Contributor Author

magnh commented Oct 14, 2024

Great, thank you @oddvernes 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants