Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover changes in 0.42.0 causes flickering #3635

Closed
havardla opened this issue Oct 3, 2024 · 5 comments · Fixed by #3639
Closed

Popover changes in 0.42.0 causes flickering #3635

havardla opened this issue Oct 3, 2024 · 5 comments · Fixed by #3639
Assignees
Labels
🐛 bug Something isn't working

Comments

@havardla
Copy link

havardla commented Oct 3, 2024

Describe the bug

When updating to 0.42.0 hovering over a button that triggers a popover causes the popover to trigger a re-render that causes flickering. This behavior is only happening on chromium based browser in a vite production build

Steps to reproduce the bug

A bit hard to reproduce since it only happens when we have this in production (cannot reproduce in localhost)

  1. Add a button that sets an open state on a popover
  2. Try to hit the button from the right side
  3. This will cause the popover to flicker until the mouse hits the middle of the button
  4. The Popover will no longer flicker until a site reload

Expected behavior

Popover to stay visible when hitting the right edge

Specifications

  • Version: 0.42.0
  • Browser: Chrome/Edge
  • OS: WIndows 11

Additional context

We are running our application in radix using vite frontend tooling

@havardla havardla added the 🐛 bug Something isn't working label Oct 3, 2024
@oddvernes
Copy link
Collaborator

oddvernes commented Oct 3, 2024

Hello! Does this happen in version 0.41.5 as well, or did it only change in 0.42.0? Because I made some changes in 0.42 to try and fix another issue in another project where the popover would not render at all unless the showPopover call was delayed. I think maybe this change should be reverted

@havardla
Copy link
Author

havardla commented Oct 3, 2024

It does not happen in 0.41.5 that we had to revert down to

@oddvernes
Copy link
Collaborator

@havardla I have made a test release with a possible fix. Would it be possible for you to test this in your prod enviroment since I am unable to reproduce this locally? npm install @equinor/eds-core-react@next if this works I'll make a patch release asap 👍

@oddvernes oddvernes self-assigned this Oct 3, 2024
@havardla
Copy link
Author

havardla commented Oct 3, 2024

Cannot seem to trigger the flickering now

@oddvernes
Copy link
Collaborator

Thanks! The fix has now been released as 0.42.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants