Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textfield multilines interaction #1155

Closed
mimarz opened this issue Mar 15, 2021 · 3 comments
Closed

Textfield multilines interaction #1155

mimarz opened this issue Mar 15, 2021 · 3 comments

Comments

@mimarz
Copy link
Contributor

mimarz commented Mar 15, 2021

Currently, when using Textfield as multiline, its resize-able to any size. With new updates to Textfield in #1152, the handle for resizing an Textfield is off-set as we changed the approach for adornments.

Currently we just suggest that setting style={{resize:none}} and applying setting rows to a value for fixing this visually.

Having our users remember to set style={{resize:none}} on every Textfield that is multiline can be cumbersome

Shoudl we maybe set resize as default to none (with a default number of rows) when multiline is set? This will make it easier for our users to use, and maybe better in terms of ux aswell? Downside of this would be that users can resize the Textfield manually, but maybe they shouldn't either.

Material-ui does not allow resizing on Textfield: https://material-ui.com/components/text-fields/#multiline

@akvam
Copy link

akvam commented Feb 16, 2022

Need a discussion on

  • What is the problem ?
  • What is the good solution ?

@mimarz
Copy link
Contributor Author

mimarz commented Aug 24, 2022

After marinating on this we suggest disabling the option for our users to resize (add resize:none; internally) as this is visually better, avoids unwanted behaviour with manual resize "flick".

Most component libraries including mui and mantine have also disabled the option for manual resize.

@mimarz
Copy link
Contributor Author

mimarz commented Sep 8, 2022

We have decided to disable resize as its provides better UX and UI because users cant freely resize the textarea and break layout.

@mimarz mimarz closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants