Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CSS variables in React components #1129

Closed
4 tasks
wenche opened this issue Feb 23, 2021 · 0 comments · Fixed by #1132
Closed
4 tasks

Add support for CSS variables in React components #1129

wenche opened this issue Feb 23, 2021 · 0 comments · Fixed by #1132
Assignees
@wenche
Labels
core-react eds-core-react

Comments

@wenche
Copy link
Contributor

wenche commented Feb 23, 2021 •
edited
Loading

This is a step on the way to provide theming in EDS.

  • Add a CSS variable with the current naming convention for all color definition inside components. Use current solution with js tokens as fallback.
  • Suggest a new naming convention
  • Rename variables to the new convention
  • Add component variables to each color definition. This will have no value from EDS, but will provide users with a way to override variables on per component level, if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenche wenche

Labels
core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some cleanup for CSS variables wenche/design-system
1 participant
@wenche