Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact Checkbox #1033

Closed
3 tasks done
pomfrida opened this issue Jan 14, 2021 · 1 comment · Fixed by #1398
Closed
3 tasks done

Compact Checkbox #1033

pomfrida opened this issue Jan 14, 2021 · 1 comment · Fixed by #1398
Assignees
@pomfrida
Labels
♿️ a11y core-react eds-core-react

Comments

@pomfrida
Copy link
Contributor

pomfrida commented Jan 14, 2021 •
edited
Loading

  • Remove paddings from the span to fit compact

  • Pressed overlay height is 40px but compact table height is 32px

  • Investigate use of multiple checkboxes in a table could use a single label header. (a11y)
@wenche wenche mentioned this issue Feb 4, 2021
Closed
@pomfrida pomfrida self-assigned this Jun 1, 2021
@pomfrida pomfrida mentioned this issue Jun 3, 2021
Merged
@pomfrida
Copy link
Contributor Author

pomfrida commented Jun 3, 2021

I think we can substitute label with aria-labelledby when used in a table. The developers can set the th id as the aria-labelledby on the checkboxes. They can also combine multiple cell ids for a more detailed labelling for the checkboxes. MDN are doing this in some of their examples.

@mimarz mimarz mentioned this issue Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomfrida pomfrida

Labels
♿️ a11y core-react eds-core-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Compact Checkbox pomfrida/design-system
1 participant
@pomfrida