Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Use fixture (go-vcr) tests when available #223

Open
displague opened this issue Dec 9, 2020 · 0 comments
Open

Use fixture (go-vcr) tests when available #223

displague opened this issue Dec 9, 2020 · 0 comments

Comments

@displague
Copy link
Contributor

displague commented Dec 9, 2020

Very little is tested in this repository when a PR is created.
(make test BUILD=local: https://github.com/packethost/packngo/blob/master/Makefile#L34-L35)

With the go-vcr support that is currently present but disabled, we could start testing every function that has a recorded test and skip any test that doesn't have a recording. This will help us reach the goal of having fixtures for every test (and transition from disabled to play by default for PACKNGO_TEST_RECORDER).

I propose, when PACKNGO_TEST_ACTUAL_API=1 and PACKNGO_TEST_RECORDER=play and -test.short=1 is set, we ONLY skip tests without fixtures.

See https://github.com/packethost/packngo/blob/master/CONTRIBUTING.md#acceptance-tests for more context.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant