Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

FacilityID is not documented correctly in README #85

Closed
displague opened this issue Jun 17, 2020 · 1 comment
Closed

FacilityID is not documented correctly in README #85

displague opened this issue Jun 17, 2020 · 1 comment

Comments

@displague
Copy link
Contributor

displague commented Jun 17, 2020

The facility-id json parameter of a cloud-sa.json file (mounted from a secret) is documented as facilityID.

Users would also benefit from a change in this wording "should contain the following keys", to describe that facilityID is optional, falling back to metadata: https://github.com/packethost/csi-packet/blob/e29bd36dbeb52470ce60d68076ee77b5d4f3518b/pkg/packet/provider.go#L58

Any other optional properties should be disclosed as such as well.

Relates to #62

@displague
Copy link
Contributor Author

Will not fix - see #103 (Equinix Metal Block Storage from Datera is EOL).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant