feat: metal_vlan_info supports facility based vlans #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vlans can be facility based, but the current metal_vlan_info code doesn't handle that case - it fails since a facility based vlan doesn't have the metro field, which is treated as required by the VLAN_RESPONSE_ATTRIBUTE_MAP.
this PR changes the metro attribute to be optional, and adds a new optional attribute for the facility, so it can handle both cases
addresses #195