Fix L2 reorg #196
Merged
Fix L2 reorg #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
reviewed
Mar 14, 2022
CHr15F0x
approved these changes
Mar 14, 2022
Mirko-von-Leipzig
force-pushed
the
fix_l2_reorg
branch
from
571befe
to
782bcda
Compare
The L2 sync process was not using the new head after a reorg event. This resulted in it continuing on from the old, now reorg'd state.
This could occur after an L2 reorg; where the same contract would be added again.
Mirko-von-Leipzig
force-pushed
the
fix_l2_reorg
branch
from
782bcda
to
b855b49
Compare
koivunej
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in the L2 sync process:
As an aside this really should have been caught by tests -- which I didn't write due to time crunch.