Support Alchemy in get_logs #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From `ethereum::tests` to `ethereum`.
Alchemy uses a different error format.
Currently supports Infura and Alchemy services.
Mirko-von-Leipzig
force-pushed
the
alchemy_get_logs
branch
from
f7b34b6
to
a7c94c8
Compare
Alchemy gives custom server errors for: - query exceeded timeout, and - query block range includes an unknown block number
Mirko-von-Leipzig
requested review from
CHr15F0x,
koivunej and
kkovaacs
and removed request for
koivunej
CHr15F0x
approved these changes
Mar 8, 2022
| Err(web3::Error::Rpc(err)) if err.code.code() == RpcErrorCode::LimitExceeded.code() => { | ||
| return Err(GetLogsError::QueryLimit) | ||
| Err(Rpc(err)) if err.code.code() == LimitExceeded.code() => { | ||
| return Err(GetLogsError::QueryLimit); |
There was a problem hiding this comment.
Maybe it would be useful to trace! when we hit the limit on infura & alchemy too?
There was a problem hiding this comment.
I wasn't sure since its a valid, expected response. And it does occur quite regularly. If anything I guess one would add these traces in the calling function?
There was a problem hiding this comment.
Oh,if it happens often then yes, definitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Alchemy Ethereum endpoint.
Background
Querying for Ethereum logs can result in a filter range which is too large i.e. the query would return too many values. Generally, the Ethereum endpoint returns the
LimitExceededRPC error, however it turns out the Alchemy usesInvalidParamsto indicate this instead.In addition, Alchemy also throws custom errors when
This PR includes supporting those.
Other included work
Our CI currently only run Ethereum tests against the Infura endpoint specified in our Github secrets. I've added secrets for Alchemy and renamed the secrets to be less general. The CI now runs the Ethereum tests twice, once each for Infura and Alchemy endpoints.
Other comments
Overall, this Ethereum "interface" could use a larger refactor including a CI overhaul to make testing these specific endpoints more obvious. And adding dependency injection for things like
get_logsand other related, more complicated things so that we can test scenarios without relying on an actual Ethereum endpoint directly.As part of this overhaul we should also somehow test / imitate other likely Ethereum node types directly if possible.
Closes #42.