fix(sync): inject a state object instead of using a global state #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
approved these changes
Mar 4, 2022
kkovaacs
force-pushed
the
krisztian/fix-sync-state-test
branch
from
d831541
to
95d67d5
Compare
Mirko-von-Leipzig
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
LGTM. Nice :D Just the new -> default, otherwise good to go.
Don't think this exists, but would be nice to restrict RPC to some read-only primitive somehow. Like a RdWrLock but one that splits into a single RdWrLock and a cloneable RdLock variant (like a channel).
| use web3::{transports::Http, Web3}; | ||
|
|
||
| use crate::rpc::types::reply::Syncing as SyncStatus; | ||
|
|
||
| lazy_static::lazy_static!( | ||
| // TODO: consider using a broadcast channel instead for easier testing. |
There was a problem hiding this comment.
Heh I see I did somewhat think about this.
RPC and sync code now gets an explicit state object that is used to store
and query sync state.
This avoids issues with tests, too: previously running
`rpc::tests::syncing::{syncing,not_syncing}` in parallel would lead to
test failures.
kkovaacs
force-pushed
the
krisztian/fix-sync-state-test
branch
from
95d67d5
to
caf9d95
Compare
Mirko-von-Leipzig
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC and sync code now gets an explicit state object that is used to store
and query sync state.
This avoids issues with tests, too: previously running
rpc::tests::syncing::{syncing,not_syncing}in parallel would lead totest failures.