Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve python related errors #161

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Mar 3, 2022

This PR adjusts the python related errors to prompt the user to check their virtual env more carefully when this fails.

Copy link
Member

@CHr15F0x CHr15F0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -54,13 +54,13 @@ async fn main() -> anyhow::Result<()> {
futures::future::pending(),
)
.await
.context("Create python process for call handling")?;
.context("Creating python process for call handling. Have you setup and activate the python `VIRTUAL_ENV` in the `py` directory?")?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.context("Creating python process for call handling. Have you setup and activate the python `VIRTUAL_ENV` in the `py` directory?")?;
.context("Creating python process for call handling. Have you setup and activated the python `VIRTUAL_ENV` in the `py` directory?")?;

@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 7aaa13c into main Mar 3, 2022
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the python_error branch March 3, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants