Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose private class hashing functionality #2466

Open
t00ts opened this issue Jan 6, 2025 · 1 comment
Open

feat: Expose private class hashing functionality #2466

t00ts opened this issue Jan 6, 2025 · 1 comment
Assignees

Comments

@t00ts
Copy link
Contributor

t00ts commented Jan 6, 2025

Recently, a request was brought up for having our hashing functionality publicly accessible.

Goal is to expose this functionality in a way where it is:

  • Publicly accessible (published on crates.io)
  • Future-proof (versioned)
  • Ergonomic for 3rd-party use (public API with proper docs)

See also:
#2465

@notlesh
Copy link

notlesh commented Jan 6, 2025

Thanks for taking a look! I'm happy to come up with a cleaner solution than what #2465 proposed.

Just to be clear (esp. since the diff is a bit difficult to look at), what we need in SNOS is a small subset of the existing fn compute_cairo_class_hash().

SNOS uses it here and this value is inserted directly into the VM.

This corresponds roughly to the OS code here and here.

@t00ts t00ts self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants