Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add l1_data_gas to common::ResourceBounds and storage #2384

Closed
kkovaacs opened this issue Nov 15, 2024 · 0 comments · Fixed by #2410
Closed

Add l1_data_gas to common::ResourceBounds and storage #2384

kkovaacs opened this issue Nov 15, 2024 · 0 comments · Fixed by #2410
Assignees

Comments

@kkovaacs
Copy link
Contributor

As a follow-up to #2379 we have to add l1_data_gas to the common ResourceBounds type (and thus transactions) and properly map the feeder gateway responses to that value.

Storing this new field is also required, which adds a bit of a complication: since we're not allowed to make changes to storage DTO types already used, we'll have to add a new variant to pathfinder_storage::transaction::dto::TransactionsWithReceiptsForBlock that does contain a variant of transaction types that in turn contain an extended ResourceBounds type that has the new field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants