Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issues with distributional's native pipe usage #377

Closed
jamesmbaazam opened this issue Sep 20, 2024 · 1 comment · Fixed by #384
Closed

Potential issues with distributional's native pipe usage #377

jamesmbaazam opened this issue Sep 20, 2024 · 1 comment · Fixed by #384

Comments

@jamesmbaazam
Copy link
Member

jamesmbaazam commented Sep 20, 2024

As epiparameter imports {distributional}, which has switched to using the native pipe, thereby bumping up the required R version to be > 4.0, I thought to raise this issue so you assess the impact. Happy for you to close if not deemed one to be tracked/fixed.

Relevant issues/discussions:

@joshwlambert
Copy link
Member

Thanks for raising @jamesmbaazam. I wouldn't have spotted this as the oldest version of R we test on in {epiparameter} CI is R-oldrel currently v4.3.3, so I appreciate you raising this before any users had issues.

Bumping the minimum R version to 4.1.0 would go against the Epiverse policy of the last 5 releases, which follows the Tidyverse policy. However, I think there will be a fair number of users with >= 4.1.0 and it would still support the last 4 R versions, so I think it's sensible to make the change.

It's unclear whether {distributional} will remove the use of the |>, but I think it's easier if we make this change now, in anticipation of it or other packages increasing their versions.

As this deviates from Epiverse policy I'll make a note of the reasoning in the design principles vignette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants