Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement log rotation for PgBouncer #921 #1858

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

ar3ndt
Copy link
Contributor

@ar3ndt ar3ndt commented Nov 17, 2020

No description provided.

@ar3ndt ar3ndt requested a review from to-bar November 17, 2020 21:28
@ar3ndt ar3ndt changed the title Feature/pgbouncer log rotate Feature/pgbouncer log rotate #921 Nov 17, 2020
Copy link
Contributor

@to-bar to-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog.

@ar3ndt ar3ndt force-pushed the feature/pgbouncer-log-rotate branch from 99b51a5 to 2f3e42f Compare November 25, 2020 07:48
@ar3ndt ar3ndt requested a review from to-bar November 26, 2020 00:36
Copy link
Contributor

@to-bar to-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions as commit in my fork (not tested)

@ar3ndt
Copy link
Contributor Author

ar3ndt commented Dec 1, 2020

Please see my suggestions as commit in my fork (not tested)

thumb up - pushed and now in test

@ar3ndt
Copy link
Contributor Author

ar3ndt commented Dec 2, 2020

tests lgtm

@to-bar to-bar changed the title Feature/pgbouncer log rotate #921 Implement log rotation for PgBouncer #921 Dec 4, 2020
to-bar
to-bar previously approved these changes Dec 4, 2020
atsikham
atsikham previously approved these changes Dec 4, 2020
Copy link
Contributor

@atsikham atsikham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ar3ndt ar3ndt dismissed stale reviews from atsikham and to-bar via 1b91b22 December 4, 2020 14:01
@ar3ndt ar3ndt force-pushed the feature/pgbouncer-log-rotate branch from 2d2ab49 to 1b91b22 Compare December 4, 2020 14:01
@atsikham atsikham requested a review from to-bar December 4, 2020 14:02
Copy link
Contributor

@atsikham atsikham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes since last time, LGTM 👍

@ar3ndt ar3ndt merged commit db9e477 into hitachienergy:develop Dec 4, 2020
toszo pushed a commit to toszo/epiphany that referenced this pull request Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants