Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Refactor Apply command #2974

Closed
14 of 20 tasks
seriva opened this issue Feb 11, 2022 · 1 comment
Closed
14 of 20 tasks

[FEATURE REQUEST] Refactor Apply command #2974

seriva opened this issue Feb 11, 2022 · 1 comment
Assignees
@seriva @przemyslavic
Labels
area/development priority/medium Task with medium priority python Pull requests that update Python code type/improvement

Comments

@seriva
Copy link
Collaborator

seriva commented Feb 11, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently the Apply command, loads, validates and applies configurations in different stages. This causes the code to be messy and not easily readable. Also it causes some cases which should fail early to only fail after the Terraform apply stage.

Describe the solution you'd like

Restructure the code to:

  1. Load needed resources from files and possible existing build output
  2. Process the documents
  3. Validate the document
  4. Assert on certain edge cases
  5. Apply Terraform infrastructure (if applicable)
  6. Apply Ansible

Describe alternatives you've considered
None

Additional context
None

DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@seriva seriva changed the title [FEATURE REQUEST] Refactor Apply command. [FEATURE REQUEST] Refactor Apply command Feb 11, 2022
@seriva seriva added area/development python Pull requests that update Python code priority/medium Task with medium priority type/improvement and removed status/grooming-needed labels Feb 11, 2022
@seriva seriva self-assigned this Feb 11, 2022
@seriva seriva mentioned this issue Feb 13, 2022
Merged
@przemyslavic przemyslavic self-assigned this Feb 24, 2022
seriva added a commit that referenced this issue Feb 24, 2022
@seriva
#2974 and #2976 (#2977)
d58ceab 
- Refactored Apply command #2974
- Added option for custom terraform scripts by the user #2976
- Moved Azure specific code from TerraformRunner to APIProxy
- Seperated filetype into schema and  template types.
- Fixed tests and sorted tests imports.
@przemyslavic
Copy link
Collaborator

Every epicli command has been tested. After some minor fixes, no more issues were found.

@seriva seriva closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seriva seriva

@przemyslavic przemyslavic

Labels
area/development priority/medium Task with medium priority python Pull requests that update Python code type/improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seriva @przemyslavic