-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] eplicli preflight checks #2821
Labels
Comments
atsikham
changed the title
[FEATURE REQUEST] Preflight check for kubeconfig existance
[FEATURE REQUEST] Node-exporter preflight checks
Dec 28, 2021
Please, double check in the rest k8s apps. |
romsok24
changed the title
[FEATURE REQUEST] Node-exporter preflight checks
[FEATURE REQUEST] eplicli preflight checks
Jan 13, 2022
This was referenced Mar 9, 2022
Taking that into account, I decided to add a validation that kubeconfig (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When we run an epicli upgrade procedure on existing epiphany installation with an k8s app enabled (ie. node-exporter in daemonset mode) an upgrade procedure is failing ( stating that no clusters/build/test-node-expr/kubeconfig file was found).
Describe the solution you'd like
Perhaps we can implement some additional preflight test to ensure the k8s config file was provided by a user before starting the upgrade? We can even copy the needed kubeconfig from the k8s master cause we have an ssh key to this machine ( to be decided yet ).
Additional checks to implement:
k8s_as_cloud_service
is set totrue
only for managed K8s ornode-exporter
feature mapping is disabled when it's set totrue
. Otherwise there is an error:Describe alternatives you've considered
No
Additional context
Workarounds:
systemctl stop prometheus-node-exporter.service
one need to do it on all nodes and for persistent change it one should use
systemctl disable ...
DoD checklist
The text was updated successfully, but these errors were encountered: