Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add configuration option to Keycloak for PROXY_ADDRESS_FORWARDING env. variable #2785

Closed
9 of 13 tasks
GrzegorzKlankABB opened this issue Dec 13, 2021 · 2 comments
Assignees
Labels

Comments

@GrzegorzKlankABB
Copy link

GrzegorzKlankABB commented Dec 13, 2021

Is your feature request related to a problem? Please describe.
I would like Keycloak service to be aware of being behind HAPRoxy and inform it to use X-Forwarded-... headers for proper JWT issuer information. At the moment I manually edit keycloak stateful set to include PROXY_ADDRESS_FORWARDING environment variable.

Describe the solution you'd like
I would like Epiphany yml configuration file to have flag in auth-service application config that would translate to PROXY_ADDRESS_FORWARDING true/false value passed as environment variable to the keycloak pod. The default value can be set to false to maintain backward compatibility.

Describe alternatives you've considered

Additional context


DoD checklist

  • Changelog updated
  • COMPONENTS.md updated / doesn't need to be updated
  • Schema updated / doesn't need to be updated
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
  • Idempotency tested
  • Documentation added / updated / doesn't need to be updated
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
  • Backport tasks created / doesn't need to be backported
@plirglo
Copy link
Contributor

plirglo commented Dec 23, 2021

OS does not matter during testing process since application works in k8s cluster.
Tested on Ubuntu with application setup:

kind: configuration/applications
title: Kubernetes Applications Config
name: default
specification:
  applications:
  - name: auth-service
    enabled: true
    image_path: epiphanyplatform/keycloak:14.0.0
    use_local_image_registry: true
    service:
      proxy_address_forwarding: true

By default proxy_address_forwarding is set to false

Configuration deployed:

image.png

image.png

image.png

@plirglo
Copy link
Contributor

plirglo commented Dec 23, 2021

@przemyslavic i think we can merge this, i'm moving it to DoD, move back if you have any doubts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants